Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different threading for gdasfcst and gfsfcst #611

Closed
wants to merge 1 commit into from
Closed

Allow different threading for gdasfcst and gfsfcst #611

wants to merge 1 commit into from
+3 −2

Conversation

DavidHuber-NOAA
Copy link
Contributor

Description
Fixes #610. This change allows different threading to be specified for both GDAS and GFS forecasts.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • N/A My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • N/A Any dependent changes have been merged and published

@DavidHuber-NOAA
Copy link
Contributor Author

DavidHuber-NOAA commented Jan 27, 2022 •
edited
Loading

Taking a closer look, this fixes the threading for the GFS forecast, but the GDAS forecast then uses nth_fv3_gfs. The line mentioned by @KateFriedman-NOAA seems to be the culprit. I will close this and open a new PR when this is fixed.

@DavidHuber-NOAA DavidHuber-NOAA deleted the patch-1 branch October 17, 2022 15:21
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
MYNNsfc uniform real kind (NOAA-EMC#611)
a2e9109 
* MYNNsfc uniform real kind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate threading options for gdasfcst and gfsfcst
1 participant
@DavidHuber-NOAA